Prevalence of Antipattern for GenProg AE in the GenProg benchmarks

SEPARATE_ZVAL(elem);

call_result = call_user_function_ex(NULL, &us->object, &func_name, &retval, 0, NULL, 0, NULL TSRMLS_CC);
if (call_result == SUCCESS && retval != NULL && Z_TYPE_P(retval) == IS_ARRAY)
{ if (SUCCESS == statbuf_from_array(retval, ssb TSRMLS_CC)) ret = 0; }
else
{ if (call_result == FAILURE) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s::" USERSTREAM_STAT " is not implemented!", us->wrapper->classname); } }

< zval_ptr_dtor(&object);
---
> if (EXPECTED(*retval != object)) {
> zval_ptr_dtor(&object);
> } else {
> Z_DELREF_P(object);
> }

if (PZVAL_IS_REF(object))
{ SEPARATE_ZVAL(&object); }

if (pp - s) {
> ret->path = estrndup(s, (pp-s));
>php_replace_controlchars_ex(ret->path, (pp - s));> }"

if (pp - s) {
> ret->path = estrndup(s, (pp-s));
>php_replace_controlchars_ex(ret->path, (pp - s));> }"

zval_copy_ctor(tmp);

zend_hash_copy(tmp_ht, original_ht, (copy_ctor_func_t) zval_add_ref, (void *) &tmp, sizeof(zval *));

< htmlNodeDumpFormatOutput(buf, docp, node, 0, format);

> xmlNodeDump(buf, docp, node, 0, format);

> JSON_G(error_code) = PHP_JSON_ERROR_NONE;

< JSON_G(error_code) = PHP_JSON_ERROR_NONE;

JSON_G(error_code) = PHP_JSON_ERROR_NONE;

while (1) { __z = return_value;
__z->value.lval = (long )((int )retval != 0);
__z->type = (unsigned char)3;
break;
}

if (php_date_global_timezone_db) { tmp___1 = (timelib_tzdb const *)php_date_global_timezone_db;
} else { tmp___0 = timelib_builtin_db();
tmp___1 = tmp___0;
} tmp___2 = timelib_timezone_id_is_valid(zone, tmp___1);
if (tmp___2) { } else { php_error_docref0((char const *)((void *)0), 1 <
<
3L, "Timezone ID \'%s\' is invalid", zone);

spprintf(error, 0, "Cannot create phar '%s', file extension (or combination) not recognised or the directory does not exist", fname);

1261c1261,1263
< zend_error(E_NOTICE, "Uninitialized string offset: %ld", Z_LVAL_P(dim));

--- >
if (type != BP_VAR_IS) {
< zend_error(E_NOTICE, "Uninitialized string offset: %ld", Z_LVAL_P(dim));
< }

expr_ptr = new_expr;

persistent_id = NULL;

if(precision>FORMAT_CONV_MAX_PRECISION) {
> precision = FORMAT_CONV_MAX_PRECISION;
> }

s = ap_php_conv_10(i_num, (*fmt) == 'u', &
is_negative, &
num_buf[NUM_BUF_SIZE], &
s_len);

goto _L;

> memset(&dateobj->time->relative, 0, sizeof(struct timelib_rel_time));

2864,2865d2864
< dateobj->time->relative.weekday = 0;
< dateobj->time->relative.have_weekday_relative
= 0; 2904a2904

> memset(&dateobj->time->relative, 0, sizeof(struct timelib_rel_time)); 2912,2913d2911

< dateobj->time->relative.weekday = 0;
< dateobj->time->relative.have_weekday_relative = 0;

tmp=zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &
zone, &
zone_len) == FAILURE:if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &
zone, &
zone_len) == FAILURE) { RETURN_FALSE;
}

if (len > s1_len - offset) {
len = s1_len - offset;
}

if (len >(long )s1_len - offset) { len = (long )s1_len - offset;
}

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "zH", &
key, &
array) == FAILURE) { return;
}

MAKE_STD_ZVAL(context->
options);
array_init(context->
options);
after context = ecalloc(1, sizeof(php_stream_context));

< c.flags = CONST_PERSISTENT | CONST_CS;

---
> c.flags = CONST_PERSISTENT;

if (!(c->flags & CONST_CS)) { /* keep in mind that c->name_len already contains the '\0' */ lowercase_name = estrndup(c->
name, c->name_len-1);
zend_str_tolower(lowercase_name, c->
name_len-1);
lowercase_name = zend_new_interned_string(lowercase_name, c->name_len, 1 TSRMLS_CC); name = lowercase_name; }
else { char *slash = strrchr(c->name, '\\'); if(slash) { lowercase_name = estrndup(c->name, c->name_len-1); zend_str_tolower(lowercase_name, slash-c->name); lowercase_name = zend_new_interned_string(lowercase_name, c->name_len, 1 TSRMLS_CC); name = lowercase_name; }
else { name = c->name; }
}

< STD_PHP_INI_ENTRY("pcre.backtrack_limit", "1000000", PHP_INI_ALL, OnUpdateLong, backtrack_limit, zend_pcre_globals, pcre_globals)

---
> STD_PHP_INI_ENTRY("pcre.backtrack_limit", "100000", PHP_INI_ALL, OnUpdateLong, backtrack_limit, zend_pcre_globals, pcre_globals)

tmp = zend_parse_parameters(ht, "ZZZ|lZ", & regex, & replace, & subject, & limit, & zcount); if (tmp == (int __attribute__((__visibility__("default"))) )-1) { return; }
else { }

<TIFFGetFieldDefaulted(in, TIFFTAG_RESOLUTIONUNIT, &res_unit);

> TIFFGetField(in, TIFFTAG_RESOLUTIONUNIT, &res_unit);

if (computeInputPixelOffsets(crop, image, &offsets)) { TIFFError ("getCropOffsets", "Unable to compute crop margins"); return (-1); }

if (isTiled(tif)) { tif->tif_tilesize = TIFFTileSize(tif); if (!tif->tif_tilesize) { TIFFErrorExt(tif->tif_clientdata, module, "%s: cannot handle zero tile size", tif->tif_name); return (0); }
}
else { if (!TIFFStripSize(tif)) { TIFFErrorExt(tif->tif_clientdata, module, "%s: cannot handle zero strip size", tif->tif_name); return (0); }
}

< return (status);

> return (0);

return (status);

exit(-1);

for (; optind < argc-1 ; optind++) { char *imageCursor = argv[optind]; in = openSrcImage (&imageCursor); if (in == NULL) return (-3); if (diroff != 0 && !TIFFSetSubDirectory(in, diroff)) { TIFFError(TIFFFileName(in), "Error, setting subdirectory at %#x", diroff); (void) TIFFClose(out); return (1); }
for (;;) { config = defconfig; compression = defcompression; predictor = defpredictor; fillorder = deffillorder; rowsperstrip = defrowsperstrip; tilewidth = deftilewidth; tilelength = deftilelength; g3opts = defg3opts; if (!tiffcp(in, out) || !TIFFWriteDirectory(out)) { TIFFClose(out); return (1); }
if (imageCursor) { /* seek next image directory */ if (!nextSrcImage(in, &imageCursor)) break; }
else if (!TIFFReadDirectory(in)) break; }
TIFFClose(in);

326,327d325
< tmsize_t orig_rawcc = tif->tif_rawcc;
< 341,344c339
< * by the compression close+cleanup routines.But
<* be careful not to write stuff if we didn't add data
< * in the previous steps as the "rawcc" data may well be
< * a previously read tile/strip in mixed read/write mode. > * by the compression close+cleanup routines.

346c341
> if (tif->tif_rawcc > 0 && tif->tif_rawcc != orig_rawcc

>
if (tif->tif_rawcc > 0

if (!(tif->tif_flags&TIFF_BIGTIFF)) { uint32 m; uint32 nextdir; m = (uint32)(tif->tif_diroff); if (tif->tif_flags & TIFF_SWAB) TIFFSwabLong(&m); if (tif->tif_header.classic.tiff_diroff == 0) { /* * First directory, overwrite offset in header. */ tif->tif_header.classic.tiff_diroff = (uint32) tif->tif_diroff; (void) TIFFSeekFile(tif,4, SEEK_SET); if (!WriteOK(tif, &m, 4)) { TIFFErrorExt(tif->tif_clientdata, tif->tif_name, "Error writing TIFF header"); return (0); }
return (1); }
/* * Not the first directory, search to the last and append. */ nextdir = tif->tif_header.classic.tiff_diroff; while(1) { uint16 dircount; uint32 nextnextdir; if (!SeekOK(tif, nextdir) || !ReadOK(tif, &dircount, 2)) { TIFFErrorExt(tif->tif_clientdata, module, "Error fetching directory count"); return (0); }
if (tif->tif_flags & TIFF_SWAB)

< /* Check for overflow. */
< if (!dir->tdir_count || !w || (tsize_t)dir->tdir_count/w != cc)
< goto bad;
< 985,988c981
< tsize_t offset = dir->tdir_offset + cc;
< /* Check for overflow. */
< if ((tsize_t)dir->tdir_offset != offset - cc
< || offset > (tsize_t)tif->tif_size)

> if (dir->tdir_offset + cc > tif->tif_size)

/* Check for overflow. */ __repair_del_1009__181: { if (!dir->tdir_count || !w || (tsize_t)dir->tdir_count / w != cc) goto bad; if (!isMapped(tif)) { if (!SeekOK(tif, dir->tdir_offset)) goto bad; if (!ReadOK(tif, cp, cc)) goto bad; }
else { tsize_t offset = dir->tdir_offset + cc; /* Check for overflow. */ if ((tsize_t)dir->tdir_offset != offset - cc || offset > (tsize_t)tif->tif_size) goto bad; _TIFFmemcpy(cp, tif->tif_base + dir->tdir_offset, cc); }

if (! tmp___9) {
#line 9403 TIFFError("loadImage", "Unable to read separate strips into buffer");
#line 9404 return (-1); }in:
tmp___9 = readSeparateStripsIntoBuffer(in, read_buff, length, width, spp, dump); image->bps = bps; __repair_del_4750__24: /* CIL Label */ { }

cc = (tsize_t )(dir->tdir_count * (uint32 )w); if (! dir->tdir_count) { goto bad; } else { if (! w) { goto bad; } else { if ((int )dir->tdir_count / w != cc) { goto bad; } else { } } }

276c276
< if (tif->tif_fields && tif->tif_nfields > 0) {

---
> if (tif->tif_fields) {

289d288 < tif->tif_fields = NULL; 347c346 < if (tif->tif_fields && tif->tif_nfields > 0) {

---
> if (tif->tif_nfields > 0) {

< return tif->tif_foundfield = (ret ? *ret : NULL);

> return (ret ? *ret : NULL);

< tif->tif_flags &= ~(TIFF_BEENWRITING|TIFF_BUFFERSETUP|TIFF_POSTENCODE);

> tif->tif_flags &= ~(TIFF_BEENWRITING|TIFF_BUFFERSETUP|TIFF_POSTENCODE|TIFF_BUF4WRITE);

intTIFFFlushData1(TIFF* tif){ repair_delete:{if (tif->tif_rawcc > 0) { if (!isFillOrder(tif, tif->tif_dir.td_fillorder) && (tif->tif_flags & TIFF_NOBITREV) == 0) TIFFReverseBits((uint8*)tif->tif_rawdata, tif->tif_rawcc); if (!TIFFAppendToStrip(tif, isTiled(tif) ? tif->tif_curtile : tif->tif_curstrip, tif->tif_rawdata, tif->tif_rawcc)) return (0); tif->tif_rawcc = 0; tif->tif_rawcp = tif->tif_rawdata; } return (1);}

< return tif->tif_foundfield = (ret ? *ret : NULL);

> return (ret ? *ret : NULL);

if (test > image->width - 1) < crop->regionlist[i].x2 = image->width - 1;

if (test < 1 ) crop->regionlist[i].x2 = 0;

tmp___0 = writeCroppedImage(in, *out, image, dump, crop->combined_width, crop->combined_length, crop_buff, (int )*page, (int )total_pages); if (tmp___0) { TIFFError("writeRegions", "Unable to write new image"); return (-1); } else

> case '4': /* it's a PBM file */
> bpp = 1;
> spp = 1;
> photometric = PHOTOMETRIC_MINISWHITE;
> break; 130a138
> bpp = 8;134a143
> bpp = 8;154c163
< /* Check fo comment line */---
> /* Check for comment line */164a174,181
> switch (bpp) {> case 1:
> if (fscanf(in, " %u %u", &w, &h) != 2)
> BadPPM(infile);
> if (fgetc(in) != '\n')
> BadPPM(infile);
> break;
> case 8:169c186,187<
--->
break;
> }

exit(-2)

if( in == NULL ) return 2;

if (y < 1000) {
- PyObject *accept = PyDict_GetItemString(moddict,- "accept2dyear");
- if (accept != NULL) {
- int acceptval = PyObject_IsTrue(accept);-
if (acceptval == -1)- return 0;-
if (acceptval) {- if (0 <= y && y < 69)- y += 2000;-
else if (69 <= y && y < 100)
- y += 1900;- else {
- PyErr_SetString(PyExc_ValueError,
- "year out of range");- return 0;
- }
- if (PyErr_WarnEx(PyExc_DeprecationWarning,
- "Century info guessed for a 2-digit year.", 1) != 0)
- return 0;
- }
- }
- else
- return 0;
- }
- /* Accept 2-digit dates unless PYTHONY2K is set and non-empty */
- p = Py_GETENV("PYTHONY2K");
- PyModule_AddIntConstant(m, "accept2dyear", (long) (!p || !*p));
- /* Squirrel away the module's dictionary for the y2k check */
- moddict = PyModule_GetDict(m);
- Py_INCREF(moddict);

if (! p) { #line 925 tmp___0 = 1; } else { #line 925 if (! *p) { #line 925 tmp___0 = 1; } else { #line 925 tmp___0 = 0; } }

338c338
< q = (struct huft *) malloc (2 * sizeof *q);

---
> q = (struct huft *) malloc (3 * sizeof *q);

341c341
< hufts += 2;

---
> hufts += 3;

344a345,346
> q[2].e = 99; /* invalid code marker */
> q[2].b = 1;

c[i] += y;

< #define DEBUG_DUMPCAP
< #define DEBUG_CHILD_DUMPCAP

---
> /**#define DEBUG_DUMPCAP**/
> /**#define DEBUG_CHILD_DUMPCAP**

fprintf((FILE */* __restrict */)stderr, (char const */* __restrict */)"%s", msg);

< #define DEBUG_DUMPCAP
< #define DEBUG_CHILD_DUMPCAP

---
> /**#define DEBUG_DUMPCAP**/
> /**#define DEBUG_CHILD_DUMPCAP**

fprintf((FILE */* __restrict */)stderr, (char const */* __restrict */)"%s", msg);

< #define DEBUG_DUMPCAP
< #define DEBUG_CHILD_DUMPCAP

---
> /**#define DEBUG_DUMPCAP**/
> /**#define DEBUG_CHILD_DUMPCAP**

fprintf((FILE */* __restrict */)stderr, (char const */* __restrict */)"%s", msg);

if (!con->conditional_is_valid[dc->comp]) { if (con->conf.log_condition_handling) { TRACE("cond[%d] is valid: %d", dc->comp, con->conditional_is_valid[dc->comp]); } return COND_RESULT_UNSET; }

srv_encodings |= 1 << 4;

if (str->used == 0) return;

for (unsigned int i = 0; i < str->used - 1; i++) { if (str->ptr[i] >= ' ' && str->ptr[i] <= '~') { /* printable chars */ buffer_append_string_len(dest, &str->ptr[i], 1); } else switch (str->ptr[i]) { case '"': BUFFER_APPEND_STRING_CONST(dest, "\\\""); break; case '\\': BUFFER_APPEND_STRING_CONST(dest, "\\\\"); break; case '\b': BUFFER_APPEND_STRING_CONST(dest, "\\b"); break; case '\n': BUFFER_APPEND_STRING_CONST(dest, "\\n"); break; case '\r': BUFFER_APPEND_STRING_CONST(dest, "\\r"); break; case '\t': BUFFER_APPEND_STRING_CONST(dest, "\\t"); break; case '\v': BUFFER_APPEND_STRING_CONST(dest, "\\v"); break; default: { /* non printable char => \xHH */ char hh[5] = {'\\','x',0,0,0}; char h = str->ptr[i] / 16; hh[2] = (h > 9) ? (h - 10 + 'A') : (h + '0'); h = str->ptr[i] % 16; hh[3] = (h > 9) ? (h - 10 + 'A') : (h + '0'); buffer_append_string_len(dest, &hh[0], 4); } break; } }